You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Going in the direction of having several possible solvers. The idea is to be able to map a solver to a method that solves the dual cone projection for some U and G.
Some qp solvers are parametrized, a string is therefore not enough to define it.
Some qp solvers (proxsuite) already do regularization with a decay of the reg_eps, so this parameter could be a parameter of the solver itself
some users may want to implement their own solver (which might be very imprecise with max_iter=1 for instance) and we cannot provide an exhaustive list of all ideas that could happen
we may want the default solver to depend on what solvers are installed.
For this reason, I think we should define a (possibly private) class DualConeProjector(ABC, Callable[[Tensor, PSDMatrix], Tensor]) which would project weights. Then we can inherit from it to implement a specific solver. I think we can then provide a collection of solvers (or constructors of solver when they are parametrized).
For this reason, I think we should define a (possibly private) class DualConeProjector(ABC, Callable[[Tensor, PSDMatrix], Tensor]) which would project weights. Then we can inherit from it to implement a specific solver. I think we can then provide a collection of solvers (or constructors of solver when they are parametrized).
That would be very clean!
The other possibility would be to provide the necessary arguments as **kwargs so that they can be transmitted to the solver. Much more friendly to the beginner user, but less so to the experienced user probably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: refactorConventional commit type for any refactoring, not user-facing, and not typing or perf improvementspackage: aggregation
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going in the direction of having several possible solvers. The idea is to be able to map a solver to a method that solves the dual cone projection for some
UandG.